Fix destruct pprintast hang #1944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reproducing issue ocaml#1489
with the `(::)` constructor. Fixes ocaml/ocaml-lsp#1489
voodoos
force-pushed
the
fix-destruct-pprintast-hang
branch
from
2b4426d to
44ff26a
Compare
voodoos
added a commit
to voodoos/ocaml
that referenced
this pull request
Jun 24, 2025
This impacted Merlin. See ocaml/merlin#1944
voodoos
added a commit
to voodoos/ocaml
that referenced
this pull request
Jun 24, 2025
This impacted Merlin. See ocaml/merlin#1944
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Jun 24, 2025
CHANGES:
Tue Jun 24 16:10:42 CEST 2025
+ merlin library
- Expose utilities to manipulate typed-holes in `Merlin_analysis.Typed_hole`
(ocaml/merlin#1888)
- `locate` can now disambiguate between files with identical names and contents
(ocaml/merlin#1882)
- `occurrences` now reports stale files (ocaml/merlin#1885)
- `inlay-hints` fix inlay hints on function parameters (ocaml/merlin#1923)
- Fix issues with ident validation and Lid comparison for occurrences (ocaml/merlin#1924)
- Handle class type in outline (ocaml/merlin#1932)
- Handle locally defined value in outline (ocaml/merlin#1936)
- Fix a typer issue triggering assertions in the short-paths graph (ocaml/merlin#1935,
fixes ocaml/merlin#1913)
- Downstreamed a typer fix from 5.3.X that would trigger assertions linked
to scopes bit masks when backtracking the typer cache (ocaml/merlin#1935)
- Add a new selection field to outline results that contains the location of
the symbol itself. (ocaml/merlin#1942)
- Fix destruct hanging when printing patterns with (::). (ocaml/merlin#1944, fixes
ocaml/ocaml-lsp#1489)
- Reproduce and fix a handful of jump-to-definition (locate) issues (ocaml/merlin#1930,
fixes ocaml/merlin#1580 and ocaml/merlin#1588, workaround for ocaml/merlin#1934)
+ ocaml-index
- Improve the granularity of index reading by segmenting the marshalization
of the involved data-structures. (ocaml/merlin#1889)
+ test suite
- Add a test case illustrating wrong open order proposed in issue ocaml/merlin#1900. (ocaml/merlin#1901)
nojb
pushed a commit
to voodoos/ocaml
that referenced
this pull request
Jun 25, 2025
This impacted Merlin. See ocaml/merlin#1944
nojb
pushed a commit
to ocaml/ocaml
that referenced
this pull request
Jun 25, 2025
This impacted Merlin. See ocaml/merlin#1944
Octachron
pushed a commit
to ocaml/ocaml
that referenced
this pull request
Jun 25, 2025
This impacted Merlin. See ocaml/merlin#1944 (cherry picked from commit 62b7f45)
xvw
pushed a commit
to xvw/merlin
that referenced
this pull request
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproduces and fixes ocaml/ocaml-lsp#1489
Thanks a lot @clecat for the initial report and @qexat for the reproduction case!
The issue is actually a buggy printer in the compiler (cc @Octachron), I will open a patch upstream.