Driver: package and library arguments #1229
Open
+620
−355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonludlam
force-pushed
the
driver-document-packages
branch
from
13f6fca
to
14643c3
Compare
jonludlam
added
the
no changelog
jonludlam
commented
Oct 31, 2024
src/driver/odoc_driver.ml
Outdated
| failwith "--voodoo and --dune-style are mutually exclusive" | ||
| | false, None, None, _packages_dir, _, _ -> | ||
| failwith | ||
| "Please specify either packages (-p) or libraries (-l), not both" |
There was a problem hiding this comment.
This was bad before, now it's terrible. We should split this into multiple subcommands
jonludlam
force-pushed
the
driver-document-packages
branch
from
a0c50b1
to
14643c3
Compare
Some general tidying too.
Because we are separating libraries which might be co-located in your opam switch, it sometimes happens that a package is using types from a library without expressing it in their META files. For example, `Odoc_classify` is using the `Cmx_format` module interface, which we put in the `compiler-libs.optcomp` package. It only links against `compiler-libs.common` though, and there is no explicit dependency on `compiler-libs.optcomp` which works because the two libraries are in the same directory. This commit fixes this problem by post-processing the `Packages.t` datatype, finding hashes that aren't in any declared library dependency and adding them to the deps of that library.
jonludlam
force-pushed
the
driver-document-packages
branch
from
14643c3
to
41ba6f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are now two ways to specify what to document. Either by opam package (-p) or by findlib library (-l). In each case the dependencies are documented also.
Some general tidying too.