[new release] ledes (0.1.0)

[gborough]

Legal Electronic Data Exchange Standard

Currently supports the parsing and validation of the following formats:

• LEDES98BI

• LEDES1998B

Project page: https://github.com/lexitree-labs/LEDES
Documentation: https://lexitree-labs.github.io/LEDES/LEDES

[ivnhk]

@gborough thank you for the contribution

CI indicated a few issues. For compilers from 4.08 up to 4.14, there's an Unbound module Re.Emacs. The more precise error is

# File "lib/common.ml", line 29, characters 12-28:
# 29 |   Re.execp (Re.Emacs.compile (Re.Emacs.re "^[A-Za-z0-9]*$")) s
#                  ^^^^^^^^^^^^^^^^
# Error: Unbound module Re.Emacs

I guess this could be fixed if you specify the lower bound for re library. The latest version requires ocaml >= 4.12: https://github.com/ocaml/ocaml-re/blob/master/re.opam#L26
Maybe if you'll specify the lower version, e.g. 1.12.0, it may be okay

For versions from 5.1 through 5.3, the error is different:

#=== ERROR while compiling ledes.0.1.0 ========================================#
# context              2.3.0 | linux/x86_64 | ocaml-base-compiler.5.1.1 | pinned(https://github.com/Lexitree-Labs/LEDES/releases/download/0.1.0/ledes-0.1.0.tbz)
# path                 ~/.opam/5.1/.opam-switch/build/ledes.0.1.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ledes -j 71 @install
# exit-code            1
# env-file             ~/.opam/log/ledes-7-e1932b.env
# output-file          ~/.opam/log/ledes-7-e1932b.out
### output ###
# (cd _build/default && /home/opam/.opam/5.1/bin/ocamlc.opt -w -40 -g -bin-annot -I lib/.ledes.objs/byte -I /home/opam/.opam/5.1/lib/angstrom -I /home/opam/.opam/5.1/lib/bigstringaf -I /home/opam/.opam/5.1/lib/ptime -I /home/opam/.opam/5.1/lib/re -I /home/opam/.opam/5.1/lib/seq -no-alias-deps -open Ledes__ -o lib/.ledes.objs/byte/ledes__Common.cmo -c -impl lib/common.ml)
# File "lib/common.ml", line 376, characters 8-33:
# 376 |   match parse_string ~consume:All line_parser_greedy line with
#               ^^^^^^^^^^^^^^^^^^^^^^^^^
# Error: The function 'parse_string' has type
#          'a Angstrom.t -> string -> ('a, string) result
#        It is applied to too many arguments
# File "lib/common.ml", line 376, characters 30-33:
# 376 |   match parse_string ~consume:All line_parser_greedy line with
#                                     ^^^
#   This extra argument is not expected.

[ivnhk]

Suggested change

	"re"
	"re" {>= "1.12.0"}

[ivnhk]

Or another earlier version

[gborough]

thanks I will fix this!

[ivnhk]

I'm not entirely sure that's the issue, just my theory

[ivnhk]

I think this is a typo, you have ocaml above :)
This is supposed to be re, right?

[ivnhk]

FreeBSD is still running (yet it may fail. In that case, failure is not related to your package afaik)

Other than that, LGTM

@gborough thanks for quick fixes :)

[gborough]

FreeBSD is still running (yet it may fail. In that case, failure is not related to your package afaik)

Other than that, LGTM

@gborough thanks for quick fixes :)

Thank you Ivan!

[mseri]

Thanks all