15 packages (base_quickcheck.v0.17.1, ppx_bench.v0.17.1, etc.) #27958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Selected Jane Street ppxes updated for ppxlib 0.36.0. This should be sufficient to compile Core. |
|
For I think ppx_globalize v0.17.0 needs an upper bound on ppxlib, right? |
|
Similarly with hardcaml and others, I am not sure what needs to be bounded, probably some packages from this PR. The failures seem all to be a consequence of this PR: hardcaml``` #=== ERROR while compiling hardcaml.v0.17.0 ===================================# # context 2.3.0 | linux/x86_64 | ocaml-base-compiler.5.3.0 | file:///home/opam/opam-repository # path ~/.opam/5.3/.opam-switch/build/hardcaml.v0.17.0 # command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p hardcaml -j 71 # exit-code 1 # env-file ~/.opam/log/hardcaml-7-8ef0f8.env # output-file ~/.opam/log/hardcaml-7-8ef0f8.out ### output ### # (cd _build/default && /home/opam/.opam/5.3/bin/ocamlopt.opt -w -40 -g -I ppx/src/.ppx_hardcaml0.objs/byte -I ppx/src/.ppx_hardcaml0.objs/native -I /home/opam/.opam/5.3/lib/base -I /home/opam/.opam/5.3/lib/base/base_internalhash_types -I /home/opam/.opam/5.3/lib/base/shadow_stdlib -I /home/opam/.opam/5.3/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.3/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.3/lib/ocaml/compiler-libs -I /home/opam/.opam/5.3/lib/ocaml_intrinsics_kernel -I /home/opam/.opam/5.3/lib/ppx_derivers -I /home/opam/.opam/5.3/lib/ppx_sexp_conv -I /home/opam/.opam/5.3/lib/ppx_sexp_conv/expander -I /home/opam/.opam/5.3/lib/ppxlib -I /home/opam/.opam/5.3/lib/ppxlib/ast -I /home/opam/.opam/5.3/lib/ppxlib/astlib -I /home/opam/.opam/5.3/lib/ppxlib/metaquot_lifters -I /home/opam/.opam/5.3/lib/ppxlib/print_diff -I /home/opam/.opam/5.3/lib/ppxlib/stdppx -I /home/opam/.opam/5.3/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.3/lib/ppxlib_jane -I /home/opam/.opam/5.3/lib/sexplib0 -I /home/opam/.opam/5.3/lib/stdlib-shims -intf-suffix .ml -no-alias-deps -open Ppx_hardcaml0 -o ppx/src/.ppx_hardcaml0.objs/native/ppx_hardcaml0__Ppx_hardcaml_zero.cmx -c -impl ppx/src/ppx_hardcaml_zero.pp.ml) # File "ppx/src/ppx_hardcaml_zero.ml", lines 880-885, characters 10-11: # 880 | ..........{ pvb_pat # 881 | ; pvb_expr = # 882 | [%expr [%e generate_naming_function ~arg ~loc ~name:txt] [%e pvb_expr]] # 883 | ; pvb_attributes # 884 | ; pvb_loc # 885 | } # Error: Some record fields are undefined: "pvb_constraint" # (cd _build/default && /home/opam/.opam/5.3/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I ppx/src/.ppx_hardcaml0.objs/byte -I /home/opam/.opam/5.3/lib/base -I /home/opam/.opam/5.3/lib/base/base_internalhash_types -I /home/opam/.opam/5.3/lib/base/shadow_stdlib -I /home/opam/.opam/5.3/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.3/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.3/lib/ocaml/compiler-libs -I /home/opam/.opam/5.3/lib/ocaml_intrinsics_kernel -I /home/opam/.opam/5.3/lib/ppx_derivers -I /home/opam/.opam/5.3/lib/ppx_sexp_conv -I /home/opam/.opam/5.3/lib/ppx_sexp_conv/expander -I /home/opam/.opam/5.3/lib/ppxlib -I /home/opam/.opam/5.3/lib/ppxlib/ast -I /home/opam/.opam/5.3/lib/ppxlib/astlib -I /home/opam/.opam/5.3/lib/ppxlib/metaquot_lifters -I /home/opam/.opam/5.3/lib/ppxlib/print_diff -I /home/opam/.opam/5.3/lib/ppxlib/stdppx -I /home/opam/.opam/5.3/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.3/lib/ppxlib_jane -I /home/opam/.opam/5.3/lib/sexplib0 -I /home/opam/.opam/5.3/lib/stdlib-shims -intf-suffix .ml -no-alias-deps -open Ppx_hardcaml0 -o ppx/src/.ppx_hardcaml0.objs/byte/ppx_hardcaml0__Ppx_hardcaml_zero.cmo -c -impl ppx/src/ppx_hardcaml_zero.pp.ml) # File "ppx/src/ppx_hardcaml_zero.ml", lines 880-885, characters 10-11: # 880 | ..........{ pvb_pat # 881 | ; pvb_expr = # 882 | [%expr [%e generate_naming_function ~arg ~loc ~name:txt] [%e pvb_expr]] # 883 | ; pvb_attributes # 884 | ; pvb_loc # 885 | } # Error: Some record fields are undefined: "pvb_constraint" ```ppx_jsonaf_conv.v0.17.0ppx_quick_test.v0.17.0ppx_typed_fields.v0.17.0streamable.v0.17.0ppx_derive_at_runtime.v0.17.0ppx_quicktest.v0.17.0I am sure I have missed some, but maybe resolving these will resolve the rest as well |
|
This also looks new: |
mseri
added a commit
to mseri/opam-repository
that referenced
this pull request
May 30, 2025
due to some issues with ppxlib 0.36.0 Seen on ocaml#27958 ``` === ERROR while compiling ppx_minidebug.2.2.0 ================================# context 2.3.0 | linux/x86_64 | ocaml-base-compiler.5.3.0 | file:///home/opam/opam-repository path ~/.opam/5.3/.opam-switch/build/ppx_minidebug.2.2.0 command ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ppx_minidebug -j 255 @install exit-code 1 env-file ~/.opam/log/ppx_minidebug-7-521fc7.env output-file ~/.opam/log/ppx_minidebug-7-521fc7.out (cd _build/default && /home/opam/.opam/5.3/bin/ocamlc.opt -w -40 -g -bin-annot -bin-annot-occurrences -I .ppx_minidebug.objs/byte -I /home/opam/.opam/5.3/lib/ocaml-compiler-libs/common -I /home/opam/.opam/5.3/lib/ocaml-compiler-libs/shadow -I /home/opam/.opam/5.3/lib/ocaml/compiler-libs -I /home/opam/.opam/5.3/lib/ppx_derivers -I /home/opam/.opam/5.3/lib/ppxlib -I /home/opam/.opam/5.3/lib/ppxlib/ast -I /home/opam/.opam/5.3/lib/ppxlib/astlib -I /home/opam/.opam/5.3/lib/ppxlib/print_diff -I /home/opam/.opam/5.3/lib/ppxlib/stdppx -I /home/opam/.opam/5.3/lib/ppxlib/traverse_builtins -I /home/opam/.opam/5.3/lib/re -I /home/opam/.opam/5.3/lib/seq -I /home/opam/.opam/5.3/lib/sexplib0 -I /home/opam/.opam/5.3/lib/stdlib-shims -no-alias-deps -o .ppx_minidebug.objs/byte/ppx_minidebug.cmo -c -impl ppx_minidebug.pp.ml) File "ppx_minidebug.ml", line 67, characters 51-52: 67 | | Ptyp_alias (typ, x) -> typ2str typ ^ " as '" ^ x ^ Error: The value "x" has type "string Ppxlib.loc" = "string Location.loc" but an expression was expected of type "string" ``` Signed-off-by: Marcello Seri <[email protected]>
Looking at the errors, all of those need an upper bound on |
mseri
added a commit
that referenced
this pull request
May 30, 2025
Some missing upper bounds after #27958
aguluman
added a commit
to aguluman/opam-repository
that referenced
this pull request
Jun 8, 2025
- Add upper bound ppxlib < 0.36.0 to all 15 packages from PR ocaml#27958 - Addresses compatibility issues with ppxlib >= 0.36.0 - All packages had explicit ppxlib deps, so no conflicts field needed Modified packages: - base_quickcheck.v0.17.1 - ppx_bench.v0.17.1 - ppx_bin_prot.v0.17.1 - ppx_diff.v0.17.1 - ppx_expect.v0.17.3 - ppx_globalize.v0.17.2 - ppx_inline_test.v0.17.1 - ppx_let.v0.17.1 - ppx_optcomp.v0.17.1 - ppx_sexp_conv.v0.17.1 - ppx_stable.v0.17.1 - ppx_tydi.v0.17.1 - ppx_typerep_conv.v0.17.1 - ppx_variants_conv.v0.17.1 - ppxlib_jane.v0.17.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request concerns:
base_quickcheck.v0.17.1: Randomized testing framework, designed for compatibility with Baseppx_bench.v0.17.1: Syntax extension for writing in-line benchmarks in ocaml codeppx_bin_prot.v0.17.1: Generation of bin_prot readers and writers from typesppx_diff.v0.17.1: A PPX rewriter that genreates the implementation of [Ldiffable.S].ppx_expect.v0.17.3: Cram like framework for OCamlppx_globalize.v0.17.2: A ppx rewriter that generates functions to copy local values to the global heapppx_inline_test.v0.17.1: Syntax extension for writing in-line tests in ocaml codeppx_let.v0.17.1: Monadic let-bindingsppx_optcomp.v0.17.1: Optional compilation for OCamlppx_sexp_conv.v0.17.1: [@@deriving] plugin to generate S-expression conversion functionsppx_stable.v0.17.1: Stable types conversions generatorppx_tydi.v0.17.1: Let expressions, inferring pattern type from expression.ppx_typerep_conv.v0.17.1: Generation of runtime types from type declarationsppx_variants_conv.v0.17.1: Generation of accessor and iteration functions for ocaml variant typesppxlib_jane.v0.17.3: Utilities for working with Jane Street AST constructs🐫 Pull-request generated by opam-publish v2.5.1