Skip to content

Conversation

@tmcgilchrist
Copy link
Contributor

@tmcgilchrist tmcgilchrist commented Jun 4, 2025

Tools for the runtime events tracing system in OCaml

CHANGES:

@mseri
Copy link
Member

mseri commented Jun 9, 2025

There is a lower bound error, maybe related to dune:

#=== ERROR while compiling runtime_events_tools_bare.0.5.2 ====================#
# context              2.4.0~alpha2 | linux/x86_64 | ocaml-base-compiler.5.4.0~alpha1 | pinned(https://github.com/tarides/runtime_events_tools/releases/download/0.5.2/runtime_events_tools-0.5.2.tbz)
# path                 ~/.opam/5.4~alpha1/.opam-switch/build/runtime_events_tools_bare.0.5.2
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p runtime_events_tools_bare -j 255 @install
# exit-code            1
# env-file             ~/.opam/log/runtime_events_tools_bare-7-d7dc06.env
# output-file          ~/.opam/log/runtime_events_tools_bare-7-d7dc06.out
### output ###
# File "test/dune", line 1, characters 0-0:
# Error: Module "Test_gc_stats" is used in several stanzas:
# - test/dune:3
# - test/dune:59
# To fix this error, you must specify an explicit "modules" field in every
# library, executable, and executables stanzas in this dune file. Note that
# each module cannot appear in more than one "modules" field - it must belong
# to a single library or executable.
# File "lib/olly_common/dune", line 3, characters 12-26:
# 3 |  (libraries runtime_events unix cmdliner))
#                 ^^^^^^^^^^^^^^
# Error: Library "runtime_events" not found.
# -> required by library "olly_common" in _build/default/lib/olly_common
# -> required by executable olly_bare in bin/dune:11
# -> required by _build/default/bin/olly_bare.exe
# -> required by _build/install/default/bin/olly_bare
# -> required by _build/default/runtime_events_tools_bare.install
# -> required by alias install

@tmcgilchrist
Copy link
Contributor Author

@mseri I've updated the lower bounds for dune. The remaining failure is OCaml 5.4 caused by Jane Street dependencies not yet supporting that compiler version. I think this is good to merge.

@mseri
Copy link
Member

mseri commented Jun 24, 2025

Thanks. Once those deps are updated to support 5.4, this will appear in the revdeps and we will see if bounds are needed

@mseri mseri merged commit d0d0d2e into ocaml:master Jun 24, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants