Do not list the package itself when running opam list --depends-on/--required-by #5075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe worth looking at #3943 along the way. |
kit-ty-kate
commented
Feb 28, 2022
Mmh, this is a very distinct issue as far as I can see. |
|
Sure I just mentioned it since you are in the area. |
kit-ty-kate
force-pushed
the
rec-deps-no-refl
branch
from
9c8790b to
de8fc21
Compare
kit-ty-kate
force-pushed
the
rec-deps-no-refl
branch
from
de8fc21 to
77ade8e
Compare
kit-ty-kate
force-pushed
the
rec-deps-no-refl
branch
from
77ade8e to
3ce9a61
Compare
…required-by Remove ?including_init and always unroll the first step of OpamStd.Set.fixpoint instead
rjbou
force-pushed
the
rec-deps-no-refl
branch
from
3ce9a61 to
b1117eb
Compare
kit-ty-kate
added
PR: NEEDS UPDATE
and removed
PR: WIP
kit-ty-kate
added
the
PR: QUEUED
kit-ty-kate
removed
the
PR: QUEUED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #4804
Fixes #4446
Queued on #5317
In my opinion
OpamStd.Set.fixpointshould not return the initial set to start with, but this behaviour seems to be used extensively in the codebase and it seems too much work to entengle every uses.It would be nice to change this behaviour at some point in the future though, this might bit us again.