Enforce dry run not changing opam root #6565
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
changed the title
|
I added several tests in the PR, all are fixed. I'm looking for other tests to add, even if they are not fixed in this PR. |
rjbou
commented
Sep 4, 2025
| match OpamStateConfig.(!r.dryrun), result with | ||
| | true, Result () -> | ||
| let base f = OpamFilename.Base.of_string (OpamFilename.Dir.to_string f) in | ||
| (match OpamRepositoryBackend.get_diff (OpamFilename.Dir.of_string "/") (base srcdir) (base srcdir0) with |
There was a problem hiding this comment.
temporary hack, get_diff needs to change arguments and take absolute path, or have 2 functions.
| let srcdir = OpamPath.Switch.pinned_package root st.switch nv.name in | ||
| let srcdir = | ||
| if OpamStateConfig.(!r.dryrun) then | ||
| OpamFilename.mk_tmp_dir () |
There was a problem hiding this comment.
i didn't check if all these temp dir created are well cleaned
| ### sh pre.sh | ||
| ### OPAMVERBOSE=2 OPAMDEBUG=-5 opam switch remove dr --dry-run | ||
| ### sh post.sh | ||
| ### :2a: local switch creation : |
There was a problem hiding this comment.
then numbers doesn't make sense, to update at finalisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.