Switch the default solver from builtin-mccs+glpk to builtin-0install #6586
+348
−292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
added
AREA: SOLVER
PR: WIP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've personally been using
builtin-0installas my default solver for the past year and i haven't noticed any issues.The CI for opam-repository also uses it daily without any noticed issues from the opam-repository maintainers.
I'd like to switch to it by default for the sake of performance, and eventually in the future (3.0?), reduced dependencies (mccs depends on C++ which causes us problems on platforms such as macOS or Windows quite often) when builtin-0install is accepted by everyone and mccs can become an optional solver.
This PR is a draft at the moment because some of the accompanying changes in the testsuite seem to be highlighting some missing feature or changes that i'd like to understand first.