Replace every polymorphic uses of List.mem by a version that doesn't use Repr.equal #6644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
force-pushed
the
no-poly-list-mem
branch
2 times, most recently
from
6f5e05c to
7c0ec77
Compare
kit-ty-kate
added
the
PR: QUEUED
kit-ty-kate
force-pushed
the
no-poly-list-mem
branch
from
7c0ec77 to
3cc964c
Compare
kit-ty-kate
removed
the
PR: QUEUED
rjbou
reviewed
Aug 29, 2025
kit-ty-kate
force-pushed
the
no-poly-list-mem
branch
from
3cc964c to
affab92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clean up.
See ocaml/ocaml#9928 for the underlying reason why
Repr/(=)/Stdlib.compare/... should be avoided.Queued on top of #6442