Make the computation of pkg:opamfile match its specification #6659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kit-ty-kate
changed the title
rjbou
reviewed
Aug 29, 2025
kit-ty-kate
force-pushed
the
fix-var-opamfile
branch
from
91d7523 to
892ce35
Compare
rjbou
reviewed
Sep 1, 2025
| |> string | ||
| |> Option.some | ||
| else | ||
| None |
There was a problem hiding this comment.
To keep the same behaviour, we need to keep the old computation here to be able to retrieve the information during package's actions (build/install)
There was a problem hiding this comment.
Our own manual says:
opamfile: if the package is installed, path of its opam file, from opam internals, otherwise not defined
I'm not sure we should invite users to use _:opamfile in build/install/…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #6625
Fixes #5346