feat(): add tenant backup destType #628
Open
+61
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
powerfooI
reviewed
Nov 14, 2024
| @@ -250,6 +253,61 @@ export default function NewBackup() { | |||
| /> | |||
| </Form.Item> | |||
| </Col> | |||
|
|
|||
There was a problem hiding this comment.
Input form field Host should be added to the form if destType is not NFS. Refer to PRD to see the details.
There was a problem hiding this comment.
It was originally there
There was a problem hiding this comment.
I mean that a new field named Host should be added to the form when selecting COS, OSS, S3 or S3-Compatible.
| @@ -29,8 +29,11 @@ export default function NewBackup() { | |||
| const scheduleValue = Form.useWatch(['scheduleDates'], form); | |||
|
|
|||
| const distType = [ | |||
There was a problem hiding this comment.
This seems to be a typo. Maybe destTypes is better.
powerfooI
reviewed
Nov 14, 2024
| }, | ||
| ]} | ||
| > | ||
| <Password |
There was a problem hiding this comment.
Plain text is more proper.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add tenant backup destType( COS、S3、 S3-Compatible)
Solution Description