refactor(schedule): separate the schedule module interface #2881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # server/integration-test/src/test/java/com/oceanbase/odc/metadb/schedule/ScheduleChangeLogRepositoryTest.java # server/odc-core/src/main/java/com/oceanbase/odc/core/shared/constant/ResourceType.java # server/odc-migrate/src/main/resources/migrate/common/V_4_3_0_8__add_schedule_change_log.sql # server/odc-server/src/main/java/com/oceanbase/odc/server/web/controller/v2/ScheduleController.java # server/odc-service/src/main/java/com/oceanbase/odc/metadb/schedule/ScheduleChangeLogEntity.java # server/odc-service/src/main/java/com/oceanbase/odc/metadb/schedule/ScheduleChangeLogRepository.java # server/odc-service/src/main/java/com/oceanbase/odc/service/dlm/model/DataArchiveParameters.java # server/odc-service/src/main/java/com/oceanbase/odc/service/dlm/model/DataDeleteParameters.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/ScheduleChangeLogService.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/ScheduleService.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/ScheduleTaskService.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/flowtask/SqlPlanPreprocessor.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/CreateScheduleReq.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/DataArchiveAttributes.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/DataDeleteAttributes.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/OperationType.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/QueryScheduleParams.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/Schedule.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleChangeLog.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleChangeLogMapper.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleChangeStatus.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleMapper.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleStatus.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleTask.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleTaskDetailResp.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleTaskMapper.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleTaskParameters.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleTaskType.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/ScheduleType.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/UpdateScheduleReq.java # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/processor/AbstractDlmPreprocessor.java
# Conflicts: # server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/ScheduleService.java
guowl3
requested review from
yhilmare,
yizhouxw,
krihy,
LuckyPickleZZ and
MarkPotato777
as code owners
yhilmare
reviewed
Jul 3, 2024
...-service/src/main/java/com/oceanbase/odc/service/connection/model/CloudConnectionConfig.java
Outdated
Show resolved
Hide resolved
.../odc-service/src/main/java/com/oceanbase/odc/service/connection/model/TestConnectionReq.java
Outdated
Show resolved
Hide resolved
yizhouxw
reviewed
Jul 3, 2024
...r/odc-server/src/main/java/com/oceanbase/odc/server/web/controller/v2/DBTableController.java
Show resolved
Hide resolved
.../odc-service/src/main/java/com/oceanbase/odc/service/dlm/utils/DataArchiveConditionUtil.java
Show resolved
Hide resolved
...r/odc-service/src/main/java/com/oceanbase/odc/service/schedule/model/QuartzJobChangeReq.java
Outdated
Show resolved
Hide resolved
guowl3
commented
Jul 4, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/schedule/ScheduleService.java
Show resolved
Hide resolved
yizhouxw
approved these changes
Jul 5, 2024
guowl3
added a commit
that referenced
this pull request
Aug 2, 2024
* refactor schedule * several bugfix * bugfix * bugfix * bugfix * bugfix * bugfix * bugfix * bugfix * rollback * opt list table * bugfix * merge 24v2 into current branch. * code format * code format * response comment * fix ut * bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-feature
What this PR does / why we need it:
separate the schedule module interface and adapt the existing code accordingly
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: