Skip to content

Runtime: os_type: Cygwin -> Win32 #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Runtime: os_type: Cygwin -> Win32 #1624

merged 1 commit into from
Jun 20, 2024

Conversation

hhugo
Copy link
Member

@hhugo hhugo commented Jun 17, 2024

No description provided.

@hhugo
Copy link
Member Author

hhugo commented Jun 19, 2024

@phated, would you mind checking if this PR works for grain ? It should only affect windows.

@hhugo hhugo merged commit e1132d2 into master Jun 20, 2024
16 of 17 checks passed
@hhugo hhugo deleted the win32 branch June 20, 2024 06:18
Copy link
Contributor

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hhugo sorry for the delay. We actually override the Cygwin value to Win32 already. See https://github.com/grain-lang/grain/blob/416936b08015d4bf0e945860b646bfa00e2f14b3/compiler/src/utils/hacks.js#L4

So this should be a good change for Grain.

@hhugo
Copy link
Member Author

hhugo commented Jun 20, 2024

Cool, do you need the rest of the stubs ? I thought they were present in jsoo already.

@phated
Copy link
Contributor

phated commented Jun 20, 2024

I think they are overrides related to \ path separators instead of /

@hhugo
Copy link
Member Author

hhugo commented Jun 20, 2024

This PR now accepts both / and \. Could you try dropping your overrides with jsoo master and report if something still needs to be fixed ?

@phated
Copy link
Contributor

phated commented Jun 20, 2024

I'd love to try it, but we never solved the performance problems so our test suite doesn't complete. I forget which older version we needed to pin.

@hhugo
Copy link
Member Author

hhugo commented Jun 20, 2024

Can you try again and reopen an issue for the perf issue ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants