Reference unboxing #1958
Open
Reference unboxing #1958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vouillon
force-pushed
the
ref-unboxing
branch
2 times, most recently
from
ad356b3 to
417dc29
Compare
hhugo
reviewed
May 7, 2025
|
rebased |
vouillon
force-pushed
the
ref-unboxing
branch
2 times, most recently
from
55e92ea to
e3a93a3
Compare
vouillon
force-pushed
the
ref-unboxing
branch
4 times, most recently
from
42c5f9e to
fe4b44c
Compare
hhugo
reviewed
Sep 5, 2025
| Freevars.iter_last_free_var discard block.branch; | ||
| match block.branch with | ||
| | Pushtrap ((pc', _), _, (pc'', _)) -> | ||
| traverse (depth + 1) start_pc pc'; |
There was a problem hiding this comment.
Can you add a comment explaining why we can't optimize across try-catch ?
There was a problem hiding this comment.
I have updated the comment at the beginning of the file
hhugo
reviewed
Sep 5, 2025
Comment on lines
+50
to
+54
| let refs, _ = Int.Hashtbl.find relevant_vars pc' in | ||
| let vars = Var.Map.filter (fun x _ -> Var.Set.mem x refs) vars in |
There was a problem hiding this comment.
Is the filtering necessary ? isn't vars always a subset of refs ?
There was a problem hiding this comment.
Not when you jump outside the scope of a reference. refs is the set of references which are in scope a the beginning of block pc'; vars maps references in scope in the current block to the variables which contain their current value.
vouillon
force-pushed
the
ref-unboxing
branch
from
fe4b44c to
e0bfae3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.