Skip to content

Add support for Microdata #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

toastal
Copy link

@toastal toastal commented May 13, 2025

See: https://html.spec.whatwg.org/multipage/microdata.html

Also includes some English orthographic fixups in a separate (droppable) commit.

1

Footnotes

  1. Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute.

@toastal
Copy link
Author

toastal commented May 26, 2025

These build errors also happen on the default branch. Just did a fresh checkout to find:

File "ppx/tyxml_ppx.ml", line 381, characters 18-65:
381 |   | Pexp_function (params, constraint_, (Pfunction_body content)) ->
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: This pattern matches values of type 'a * 'b * 'c
       but a pattern was expected which matches values of type case list
Generating: index.html  

I have been using this branch in a Nix overlay for 2 weeks now.

@toastal
Copy link
Author

toastal commented May 26, 2025

It appears to me dune test fails starting at 7b11831 from #340

@toastal
Copy link
Author

toastal commented May 27, 2025

@smorimoto

@smorimoto
Copy link
Member

Could you please rebase this?

@toastal
Copy link
Author

toastal commented May 27, 2025

Local said I was up to date. I will force push again… it could have been a miss timing.

@toastal
Copy link
Author

toastal commented May 27, 2025

$ git checkout microdata 
Switched to branch 'microdata'
$ git pull --rebase upstream master
From https://github.com/ocsigen/tyxml
 * branch              master     -> FETCH_HEAD
Current branch microdata is up to date.
$ dune clean
$ dune test --stop-on-first-error
File "ppx/tyxml_ppx.ml", line 381, characters 18-65:
381 |   | Pexp_function (params, constraint_, (Pfunction_body content)) ->
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: This pattern matches values of type 'a * 'b * 'c
       but a pattern was expected which matches values of type case list

@smorimoto this is the same error the CI was giving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants