-
Notifications
You must be signed in to change notification settings - Fork 63
Add support for Microdata #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
toastal
wants to merge
5
commits into
ocsigen:master
Choose a base branch
from
toastal:microdata
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These build errors also happen on the default branch. Just did a fresh checkout to find:
I have been using this branch in a Nix overlay for 2 weeks now. |
Could you please rebase this? |
Local said I was up to date. I will force push again… it could have been a miss timing. |
$ git checkout microdata
Switched to branch 'microdata'
$ git pull --rebase upstream master
From https://github.com/ocsigen/tyxml
* branch master -> FETCH_HEAD
Current branch microdata is up to date.
$ dune clean
$ dune test --stop-on-first-error
File "ppx/tyxml_ppx.ml", line 381, characters 18-65:
381 | | Pexp_function (params, constraint_, (Pfunction_body content)) ->
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: This pattern matches values of type 'a * 'b * 'c
but a pattern was expected which matches values of type case list @smorimoto this is the same error the CI was giving |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://html.spec.whatwg.org/multipage/microdata.html
Also includes some English orthographic fixups in a separate (droppable) commit.
1
Footnotes
Please consider giving up MS GitHub or offering a non-proprietary, non-US-corporate-controlled mirror for this free software project. I wish to delete this Microsoft account in the future, but I need more projects like this to support alternative methods to send patches & contribute. ↩