fix: don't deadlock on 10+ concurrent requests needing auth #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2025
|
Can you update the PR with octokit/auth-app.js#689 |
give auth requests a dedicated queue, so that they don't cause a deadlock when too many requests are queued
jenseng
force-pushed
the
fix-auth-deadlock
branch
from
22fd013 to
16d260b
Compare
Done! I only updated the dev dependency and the test, since it can still work with older versions (just suboptimally). Let me know if we should tweak peerDependencies/etc too |
wolfy1339
reviewed
Apr 3, 2025
wolfy1339
approved these changes
Apr 3, 2025
|
🎉 This PR is included in version 9.6.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Great work on adding custom throttling for auth requests 🚀 |
jonathanmorley
added a commit
to jonathanmorley/octokit.js
that referenced
this pull request
Apr 8, 2025
To pick up this fix octokit/plugin-throttling.js#779
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #754
Fixes octokit/octokit.js#2800
Give auth requests a dedicated queue. This ensures that they don't cause a deadlock when 10+ concurrent requests are made that need authentication (i.e. either we've never authed, or the token has expired).