Skip to content

Add uploaded_blob context manager, allow calling of model clean() with overridden settings #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 28, 2025

Conversation

thclark
Copy link
Contributor

@thclark thclark commented May 28, 2025

Contents (#84)

New features

  • Add uploaded_blob context manager, useful for unit testing

Fixes

  • Allow field cleaning to happen inside an overridden context
  • Correct implementation of headers for limiting content length range
  • Make upload_blob woth with default destination path helper

Operations

  • Remove deprecated setting from devcontainer json

Refactoring

  • Remove redundant context in test

Testing

  • Test uploaded_blob context manager

Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.86%. Comparing base (50ffc67) to head (576c27b).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
django_gcp/storage/fields.py 91.17% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
+ Coverage   68.28%   68.86%   +0.57%     
==========================================
  Files          43       43              
  Lines        1996     2004       +8     
==========================================
+ Hits         1363     1380      +17     
+ Misses        633      624       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@thclark thclark merged commit c322454 into main May 28, 2025
21 checks passed
@thclark thclark deleted the override-clean branch May 28, 2025 21:23
@github-actions github-actions bot mentioned this pull request Jun 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant