Fix signature mismatch bug due to max size bytes header #86
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the previous release 0.18.0, the addition of the
X-Goog-Content-Length-Range
header was "fixed". Previously it had been incorrectly added and was thus always missing.However, this header must be identically both:
The "fix" in 0.18.0 added it into the encoding of the signature generation but did not set it on the upload request. The resulting code caused errors in all uploads using the widget.
This release fixes that problem by clarifying the default value and ensuring that the correct header is set on upload. In the event that the requested max_size_bytes is 0, the upload size is unlimited.
This release adds a setting
GCP_STORAGE_BLOBFIELD_MAX_SIZE_BYTES
allowing you to set a maximum for all your blobfields. However, to avoid a breaking change, the default is set to 0 (unlimited).Contents (#86)
Fixes
Operations
Style