fix(sys/linux): incorrect epoll_wait & EPoll_Event on arm64 & riscv64 #5646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xb-bx
changed the title
Contributor
Author
|
force-pushed to fix the typo in the commit message |
xb-bx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous code uses epoll_pwait for arm64 & riscv64 and epoll_wait for other archs, but it uses it incorrectly.
The syscall expects timeout in milliseconds but the code passes Time_Spec
new code calls epoll_pwait for all archs with NULL sigmask so it will act as epoll_wait
updated:
also fixes EPoll_Event struct always being packed, it should be packed only for x86/x86_64