runtime: Use chacha8rand as the default RNG (BREAKING) #5963
+1,486
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The switch to the new RNG will be a breaking change as the outputted sequence will change for a given seed. This is intended for backward compatibility purposes only.
This is extracted from the previos PR as an improved non-cryptographic PRNG option.
While platforms that do not have an entropy source have no rights, use something that is always guaranteed to work.
The example should run on any target, not just first class ones.
Yawning
force-pushed
the
feature/chacha8rand
branch
from
24e700a to
c55eed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the default random number generator to the chacha8rand CSPRNG seeded from system entropy.
This is a breaking change as the output for a given seed will be different than the previous PCG64 generator.
Changes:
core:math/randcore:math/randcore:crypto.rand_bytestobase:runtimeUplifting the CPUID code to runtime would allow for dynamic detection of AVX-2, but the non-bulk performance difference is not significant, so this is defered till needed.