Update option on image changed #4369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
7 times, most recently
from
00126fe to
cc1dfc7
Compare
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
2 times, most recently
from
4a2cf82 to
d6b3b39
Compare
loco-odoo
force-pushed
the
master-mysterious-egg-loco-1
branch
from
d6b3b39 to
1b882ec
Compare
FrancoisGe
reviewed
Apr 17, 2025
| const editingElements = this.env.getEditingElements(); | ||
| const promises = []; | ||
| for (const editingEl of editingElements) { | ||
| const imageEls = editingEl.querySelectorAll("img"); |
There was a problem hiding this comment.
What happens if img is the editingElement
FrancoisGe
reviewed
Apr 17, 2025
| import { useDomState } from "../utils"; | ||
| import { LoadImgComponent } from "./load_img_component"; | ||
|
|
||
| export class UpdateOptionOnImgChanged extends BuilderComponent { |
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.