Add loading screen during operation + also allow async function in mutex #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
sobo-odoo
force-pushed
the
master-mysterious-egg-sobo-2
branch
from
4d9ac90 to
329ebe8
Compare
|
This PR targets the un-managed branch odoo-dev/odoo:master-mysterious-egg, it needs to be retargeted before it can be merged. |
sobo-odoo
force-pushed
the
master-mysterious-egg-sobo-2
branch
2 times, most recently
from
35f5632 to
9b0d3f3
Compare
FrancoisGe
reviewed
Apr 16, 2025
Comment on lines
73
to
83
| // Cancel the operation if the iframe has been reloaded and | ||
| // does not have a browsing context anymore | ||
| if (!this.editableDocument.defaultView) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Check isDestroyed to know if the iframe is relaoded
Goaman
reviewed
Apr 16, 2025
| * @param {OperationParams} params | ||
| * @returns {Promise<void>} | ||
| */ | ||
| next(fn, { withLoadingEffect = true, loadingEffectDelay = 500 } = {}) { |
There was a problem hiding this comment.
we need to cancel. I would just have one next function
sobo-odoo
force-pushed
the
master-mysterious-egg-sobo-2
branch
from
9b0d3f3 to
bc9ad4b
Compare
sobo-odoo
force-pushed
the
master-mysterious-egg-sobo-2
branch
from
bc517cb to
228d827
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.