Skip to content

[ADD] general: cloud storage #12899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

xpl-odoo
Copy link
Contributor

task-4329079

@robodoo
Copy link
Collaborator

robodoo commented Apr 15, 2025

Pull request status dashboard

@xpl-odoo xpl-odoo requested a review from HydrionBurst April 15, 2025 12:47
@C3POdoo C3POdoo requested a review from a team April 15, 2025 12:59
@xpl-odoo xpl-odoo removed the request for review from a team April 16, 2025 08:10
Copy link
Contributor

@HydrionBurst HydrionBurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the documentation. LGTM 👍

just some nitpickings.

Cloud storage
=============

The cloud storage integration allows to store mail chatter and mail composer attachments on the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if technical terminoloies mail chatter and mail composer are clear enough for readers.
Maybe confirm those words with po

Comment on lines 255 to 256
#. :ref:`Install <general/install>` the :guilabel:`Cloud Storage` and :guilabel:`Cloud Storage
Azure` modules.
Copy link
Contributor

@HydrionBurst HydrionBurst Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud Storage Azure depends on Cloud Storage
We can ask customers to only install Cloud Storage Azure

Same for the Cloud Storage Google

@xpl-odoo xpl-odoo force-pushed the 18.0-general-cloud-storage-xpl branch from 1a6fba2 to 2ea2cb3 Compare April 17, 2025 14:55
@@ -0,0 +1,271 @@
=============
Cloud storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Cloud Storage

Be consistent with other names e.g. Google Translate Barcode Lookup

@xpl-odoo xpl-odoo force-pushed the 18.0-general-cloud-storage-xpl branch from 2ea2cb3 to f164555 Compare April 18, 2025 07:34
@xpl-odoo
Copy link
Contributor Author

@robodoo r+

=============

The cloud storage integration allows to store :doc:`chatter <../../productivity/discuss/chatter>`
and email attachments on the :ref:`Google Cloud <cloud-storage/google>` or :ref:`Microsoft Azure
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to push this comment

email attachments

Technically only attachments in chatter will be uploaded to cloud storage. And Send Message just use attachments in the chatter for email.
For those email attachments, I remember they are either

  1. url attachemnt => sent as an odoo link / url link ? not sure
  2. normal attachment
  • not too big (~10MB ?) => sent directly as binary email attachment
  • too big => send as an odoo link (because email service providers e.g. Gmail/Outlook have attachment size limitation)
  1. cloud storage attachment => sent as an odoo link (users click the odoo link and odoo server will check the access rights and then generate a cloud storage link with access token and redirect users)

So many attachments in email are actually not in cloud storage. For example attachemnts in the email for a sign request in Sign

Could you double check if the name is accurate enough? Or may be we say email attachments we always mean the Send Message in chatter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants