[FIX] translation: replace placeholders even if translation is not loaded

Before this commit, if the translation was not loaded, the placeholders
were not replaced.

closes #4242

Task: 0
X-original-commit: ca535ad
Signed-off-by: Adrien Minne (adrm) <[email protected]>
Signed-off-by: Pierre Rousseau (pro) <[email protected]>

Author: pro-odoo

src/translation.ts

@@ -40,7 +40,7 @@ class LazyTranslatedString extends String {
 
   valueOf() {
     const str = super.valueOf();
-    return _loaded() ? sprintf(_translate(str), ...this.values) : str;
+    return _loaded() ? sprintf(_translate(str), ...this.values) : sprintf(str, ...this.values);
   }
   toString() {
     return this.valueOf();

tests/helpers/translation_helpers.test.ts

@@ -1,4 +1,4 @@
-import { _t } from "../../src/translation";
+import { _t, setTranslationMethod } from "../../src/translation";
 
 describe("Translations", () => {
   test("placeholders in string translation are replaced with their given value", () => {
@@ -21,4 +21,13 @@ describe("Translations", () => {
   test("can have named placeholders", () => {
     expect(_t("%(x1)s %(thing)s", { x1: "Hello", thing: "World" })).toBe("Hello World");
   });
+
+  test("should replace placeholders even if the translation is not loaded", () => {
+    setTranslationMethod(
+      (str, ...values) => str,
+      () => false
+    );
+    const str = _t("%(x1)s %(thing)s", { x1: "Hello", thing: "World" });
+    expect(`${str}`).toBe("Hello World");
+  });
 });