[FIX] font_size_editor: dropdown and outline issues #5273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dhrp-odoo
force-pushed
the
17.0-fix-font-size-editor-bugs-dhrp
branch
from
91279df to
723dd3e
Compare
Issue 1: Adjusting the font size with the mouse wheel while the dropdown is open caused the onChange event to trigger when clicking on a font size in the list. This applied the wheel-adjusted font size, closed the dropdown, and prevented the selected size from being applied. Keeping the dropdown open resulted in the font size being set twice, which was also undesirable. To resolve this, the setSize function now uses a 100ms debounce. This ensures the font size is updated only once when both onChange and onClick events are triggered. Issue 2: The focus outline for the font size editor was not visible due to a global CSS reset in Odoo. To align with the design, the input outline has been removed in o-spreadsheet as well. Task: 4357023
dhrp-odoo
force-pushed
the
17.0-fix-font-size-editor-bugs-dhrp
branch
from
723dd3e to
513fdbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Issue 1:
Adjusting the font size with the mouse wheel while the dropdown is open caused the
onChangeevent to trigger when clicking on a font size in the list, applying the wheel-adjusted font size, closing the dropdown, and preventing the selected size from being applied. Keeping the dropdown open resulted in the font size being set twice, which was also undesirable. To resolve this, thesetSizefunction now uses a 100ms debounce, ensuring the font size is updated only once when bothonChangeandonClickevents are triggered.Issue 2:
The focus outline for the font size editor was not visible due to a global CSS reset in Odoo. To align with the design, the input outline has been removed in
o-spreadsheetas well.Task: 4357023
review checklist