[IMP] model: create snapshot when loading xlsx file #5320
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
14 tasks
Rachico
force-pushed
the
18.0-snapshot-when-open-xlsx-mera
branch
2 times, most recently
from
d4ac9cd to
1bbd91a
Compare
pro-odoo
requested changes
Dec 20, 2024
Rachico
force-pushed
the
18.0-snapshot-when-open-xlsx-mera
branch
2 times, most recently
from
4804a36 to
adb4f86
Compare
LucasLefevre
requested changes
Jan 2, 2025
Rachico
force-pushed
the
18.0-snapshot-when-open-xlsx-mera
branch
from
adb4f86 to
ec339bc
Compare
Before this commit, when uploading an XLSX file, the code in the Odoo repository would create a spreadsheet document with data that is encoded in xml. Whenever the file is loaded, we parse the stringified xml to convert it to the o-spreadsheet json structure. The problem is that this conversion can be quite slow and costly when the XLSX file is large. This commit mitigates the issue by saving a snapshot once the XLSX file is loaded for the first time. Task: 4080514
Rachico
force-pushed
the
18.0-snapshot-when-open-xlsx-mera
branch
from
ec339bc to
ffd9080
Compare
This was referenced Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when uploading an XLSX file, the code in the Odoo repository would create a spreadsheet document with data that is encoded in xml. Whenever the file is loaded, we parse the stringified xml to convert it to the o-spreadsheet json structure. The problem is that this conversion can be quite slow and costly when the XLSX file is large.
This commit mitigates the issue by saving a snapshot once the XLSX file is loaded for the first time.
Task: 4080514
review checklist