[PERF] import xlsx: avoid reading all cells multiple times during table_conversion #6057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
the commit title could point towards the global context in which it is used, which is the Xlsx import if i'm not. mistaken? |
…le_conversion Previously, the content of each cell was inspected multiple times, once per table, leading to significant performance overhead. In this commit, the inspection process is optimized to traverse the cells only once. A data structure now stores only the cells that need to be updated, improving both efficiency and calculation time. This optimization results in a 10% reduction in total import time. task: 4699860
laa-odoo
force-pushed
the
16.0-table_conversion-convertTableFormulaReferences-perf-laa
branch
from
0892c7c to
1d250b1
Compare
in fact this concerns the xlsx import, the name of the commit has been changed |
laa-odoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the content of each cell was inspected multiple times, once per table, leading to significant performance overhead. In this commit, the inspection process is optimized to traverse the cells only once.
A data structure now stores only the cells that need to be updated, improving both efficiency and calculation time.
This optimization results in a 10% reduction in total import time.
Task: 4699860