[IMP] filter: fix horrible performances with huge data filters #6286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo/o-spreadsheet:master-data-filter-rule-adrm, it needs to be retargeted before it can be merged. |
hokolomopo
force-pushed
the
master-data-filter-rule-adrm
branch
2 times, most recently
from
d89b946 to
55e57a3
Compare
rrahir
force-pushed
the
master-data-filter-rule-adrm
branch
from
55e57a3 to
8fdbfad
Compare
On a spreadsheet with 10,000 rows, opening the filter menu and filtering all the values is really slow. This commit improves the performance of the existing functions, and adds a `load more` button in the filter menu to avoid creating 10000 owl components and DOM elements. On a data filter with 10,000 rows: - `getFilterHiddenValues` (when opening filter menu): ~1000ms => ~70ms - `updateHiddenRows` (when filtering all values): ~543ms => ~8ms Task: 4658998
hokolomopo
force-pushed
the
master-data-filter-huge-dataset-adrm
branch
from
5ea8849 to
4e47bc9
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a spreadsheet with 10,000 rows, opening the filter menu and filtering all the values is really slow.
This commit improves the performance of the existing functions, and adds a
load morebutton in the filter menu to avoid creating 10000 owl components and DOM elements.On a data filter with 10,000 rows:
getFilterHiddenValues(when opening filter menu): ~1000ms => ~70msupdateHiddenRows(when filtering all values): ~543ms => ~8msTask: 4658998
review checklist