Skip to content

[FIX] grid overlay: avoid bazillions of useless renders#6325

Open
hokolomopo wants to merge 1 commit intosaas-18.3from
saas-18.3-bazillion-useless-renders-adrm
Open

[FIX] grid overlay: avoid bazillions of useless renders#6325
hokolomopo wants to merge 1 commit intosaas-18.3from
saas-18.3-bazillion-useless-renders-adrm

Conversation

@hokolomopo
Copy link
Contributor

The grid overlay would trigger a re-render for each mouse move event. That's a bit much. A render is only useful when:

  1. we're in dashboard mode
  2. the hovered cell has changed

Task: 0

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

The grid overlay would trigger a re-render for each mouse move event.
That's a bit much. A render is only useful when:

1) we're in dashboard mode
2) the hovered cell has changed

Task: 0
@robodoo
Copy link
Collaborator

robodoo commented May 8, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants