[FIX] grid overlay: avoid bazillions of useless renders#6325
Open
hokolomopo wants to merge 1 commit intosaas-18.3from
Open
[FIX] grid overlay: avoid bazillions of useless renders#6325hokolomopo wants to merge 1 commit intosaas-18.3from
hokolomopo wants to merge 1 commit intosaas-18.3from
Conversation
The grid overlay would trigger a re-render for each mouse move event. That's a bit much. A render is only useful when: 1) we're in dashboard mode 2) the hovered cell has changed Task: 0
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The grid overlay would trigger a re-render for each mouse move event. That's a bit much. A render is only useful when:
Task: 0
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist