-
Notifications
You must be signed in to change notification settings - Fork 70
[IMP] composer: prettify formula when content is too long. #6435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c07c60a to
77593ff
Compare
746dac9 to
4e3da34
Compare
8cf57f7 to
c6f90e7
Compare
286408c to
c31c788
Compare
rrahir
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a pending review, probably for a month ><
tests/composer/auto_complete/function_auto_complete_store.test.ts
Outdated
Show resolved
Hide resolved
c31c788 to
e294ee9
Compare
thx for the review :) |
LucasLefevre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the blog post you used implements a known/academic algorithm ?
0b856f7 to
e37b59b
Compare
LucasLefevre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more detail comments to make it extra-perfect.
It's looking good 👍
e1da7b0 to
90717d7
Compare
Prettify formula depending on the content width. task: 4735172 Co-authored-by: lul-odoo <[email protected]>
90717d7 to
eb41131
Compare
LucasLefevre
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
robodoo r+
Prettify formula depending on the content width. closes #6435 Task: 4735172 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Co-authored-by: lul-odoo <[email protected]>

Task: 4735172