Skip to content

[FW][FIX] pivot: support sorted column with field name #6533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jun 4, 2025

Description:

Fix for an upgrade issue: the sortedColumn measure was not updated from using fieldName to using id. If the sortedColumn measure matches a measure fieldName in the definition, update it to use the measure's id instead of its fieldName.

Task: 4816705

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #6473

Fix for an upgrade issue: the sortedColumn measure was not updated
from using fieldName to using id. If the sortedColumn measure matches
a measure fieldName in the definition, update it to use the measure's id instead
of its fieldName.

Task: 4816705
X-original-commit: c737e58
@robodoo
Copy link
Collaborator

robodoo commented Jun 4, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jun 4, 2025

This PR targets saas-18.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jun 6, 2025

@LucasLefevre @pro-odoo child PR #6534 was modified / updated and has become a normal PR. This PR (and any of its parents) will need to be merged independently as approvals won't cross.

@pro-odoo
Copy link
Collaborator

pro-odoo commented Jun 6, 2025

robodoo r+

robodoo pushed a commit that referenced this pull request Jun 6, 2025
Fix for an upgrade issue: the sortedColumn measure was not updated
from using fieldName to using id. If the sortedColumn measure matches
a measure fieldName in the definition, update it to use the measure's id instead
of its fieldName.

closes #6533

Task: 4816705
X-original-commit: c737e58
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
@robodoo robodoo closed this Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants