Skip to content

[FIX] model: ensure chart ID unicity #7283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[FIX] model: ensure chart ID unicity #7283

wants to merge 1 commit into from
+32 −0

Conversation

hokolomopo
Copy link
Contributor

Description

We have a function forceUnicityOfFigure that repair the spreadsheet data at import to force the figure ID unicity. But since the introduction of carousels, we also need to ensure the chart ID unicity (after the migration, chart ID and figure ID are the same).

Task: 5153264

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

@hokolomopo
[FIX] model: ensure chart ID unicity
3755eda 
We have a function `forceUnicityOfFigure` that repair the spreadsheet
data at import to force the figure ID unicity. But since the
introduction of carousels, we also need to ensure the chart ID unicity
(after the migration, chart ID and figure ID are the same).

Task: 5153264
@robodoo
Copy link
Collaborator

robodoo commented Oct 8, 2025

Pull request status dashboard

pro-odoo
pro-odoo approved these changes Oct 20, 2025
View reviewed changes
Copy link
Collaborator

@pro-odoo pro-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

robodoo r+

robodoo pushed a commit that referenced this pull request Oct 20, 2025
@hokolomopo
[FIX] model: ensure chart ID unicity
870070e 
We have a function `forceUnicityOfFigure` that repair the spreadsheet
data at import to force the figure ID unicity. But since the
introduction of carousels, we also need to ensure the chart ID unicity
(after the migration, chart ID and figure ID are the same).

closes #7283

Task: 5153264
Signed-off-by: Pierre Rousseau (pro) <[email protected]>
@robodoo
Copy link
Collaborator

robodoo commented Oct 20, 2025

@hokolomopo @pro-odoo staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/batch/2189604/build/91582939)

@pro-odoo
Copy link
Collaborator

robodoo retry

@robodoo robodoo closed this in cb66cfd Oct 20, 2025
@fw-bot fw-bot mentioned this pull request Oct 20, 2025
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pro-odoo pro-odoo pro-odoo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hokolomopo @robodoo @pro-odoo