[FIX] range: invalid sheet name with special character #7337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have a range with an invalid sheet name, the sheet name is not escaped with quotes when it contains special characters when converting the range back to a string. Task: 5125762
|
|
hokolomopo
commented
Oct 15, 2025
| const cfs = data.sheets[1].conditionalFormats; | ||
| const rule1 = cfs[0].rule as ColorScaleRule; | ||
| expect(cfs[0].ranges).toEqual(["=sheetName_!A1:A2"]); | ||
| expect(cfs[0].ranges).toEqual(["'=sheetName_'!A1:A2"]); |
There was a problem hiding this comment.
This whole test is both totally broken, and it highlight some problematic behaviors:
Broken because:
- in the spreadsheet data, it uses
figure.typeinstead offigure.tag. So Charts are never actually created. - it creates a sheet with invalid characters in its name such as
sheetName?, but the ranges of the charts/cfs are=sheetName!, an invalid sheet name that does not exist (notice the=, those are ranges and not formulas)
Strange behavior highlighted
- cfs formulas are stored as string in the plugin, and exported as it in the data. So they never go though the createRange/toRangeString moulinette. So sheet name with wrong character are never escaped.
Not sure if we want/need to fix that.
There was a problem hiding this comment.
@rrahir didn't we talk about this test sometime ? I kinda remember something like that
There was a problem hiding this comment.
I do recall that as well, I think we agreed to fix it in later versions (specifically when it came to introduce the carousel but I might be wrong) I don't recall what we put in place though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If we have a range with an invalid sheet name, the sheet name is not escaped with quotes when it contains special characters when converting the range back to a string.
Task: 5125762
review checklist