[FIX] when deleting a build, kill its instance #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-introduces a features dropped in Odoo 9.0: being able to mark a returned picking "to be refunded". This is a backport of this commit for Odoo 10: odoo/odoo@f37681e See also odoo/odoo#12790 opw-682681
hbrunn
force-pushed
the
master-kill_on_delete
branch
from
cce8165 to
05a4d5c
Compare
|
@hbrunn if you are still willing to propose this PR, you need to clean it up from unrelated module |
hhgabelgaard
pushed a commit
to steingabelgaard/odoo-extra
that referenced
this pull request
Mar 23, 2019
…com/owner/repository.name.git to sent github statuses" (odoo#93) Reverts Vauxoo#91 Final solution was change the repository of name removing dots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experience problems with claimed port numbers, which is caused by build being cleaned up without being killed befor, so I think the best place to take care of this globally is during
unlink().