Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase visibility of outstanding forward ports #801

Open
xmo-odoo opened this issue Aug 14, 2023 · 1 comment
Open

Increase visibility of outstanding forward ports #801

xmo-odoo opened this issue Aug 14, 2023 · 1 comment
Labels
forwardbot

Comments

@xmo-odoo
Copy link
Collaborator

xmo-odoo commented Aug 14, 2023 •
edited
Loading

As of this update (2025-01-17) >200 oustanding forward ports (fw or PRs merged more than one week ago)

  • oldest one is going on two years
  • one team has successfully reached 3 digits

problems

  • the metric / display is actually kinda shit, because the forward port can be an hour old but if its PR was merged last week it's outstanding (this is not impossible for complex PRs, or bad weeks with lots of non-deterministic failures, it can take a while for each forward port to be merged and give access to the next one) done, outdating is now based on the creation date of the forward port
  • also some forward ports could be counted twice? The sum of all team counters can be more than the outstanding count because outstandings are counted towards both the author and the reviewer, but it doesn't really make sense at the team level... indeed if both author and reviewer are in the same team (e.g. self-review) then the forward ports would be counted twice towards the team's tally, which doesn't make sense
  • reminders are on an exponential backoff based on merge date, so no reminders when a blocked fw is finally merged and the next one is created done, reminders are now linear (initially weekly then monthly (actually every 4 weeks)
  • what if the reviewiewer changed team (or job)?
  • how many people conveniently decide they're bankrupt on github notifications? added email reminders at 6 months
  • people don't watch them
    • if logged in (does that happen?) the user should see their own status
      • that specific info should be in the default box, and the default view of the page
      • if concept of team leads, should also be in the view

possible solutions

  • responsibility handoff
    • store team of approver, start slinging?
  • more aggressive reminders? (e.g. cap backoff)
  • email?
  • odoo / discord messages?
  • block new PRs?
@xmo-odoo xmo-odoo moved this to ideas in Mergebot May 29, 2024
@xmo-odoo xmo-odoo changed the title Reminder email on outstanding forward ports Increase visibility of outstanding forward ports Jan 17, 2025
@xmo-odoo xmo-odoo moved this from accepted to done in Mergebot Jan 28, 2025
@xmo-odoo
Copy link
Collaborator Author

Marking as done as most of the items are resolved, the team move / handoff / ... issue should probably be handled in #968 as the reassignment of people is very much involved.

xmo-odoo added a commit that referenced this issue Jan 29, 2025
@xmo-odoo
[IMP] forwardport: outstanding FP reminders
942570e 
- only remind weekly initially (not daily)
- root reminders on the forward port's creation, not the source's
  merge date
- cap reminder interval at 4 weeks (instead of doubling every time)
- track reminders on forward ports, don't share between siblings
- remove `forwardport_updated_before` from the testing system, it's
  now possible to just update `reminder_next` to a past date and see
  if it gets triggered (it should to nothing on sources, or on forward
  port in a state which does not warrant concern)

Fixes #801
xmo-odoo added a commit that referenced this issue Jan 29, 2025
@xmo-odoo
[IMP] forwardport: classify FP as outstanding a week after creation
60b8449 
Rather than a week after *source merge*.

Fixes #801
xmo-odoo added a commit that referenced this issue Jan 29, 2025
@xmo-odoo
[FIX] forwardport: avoid double counting PRs for teams
63a4916 
In the case where both author and reviewer of a PR have the same
team (which is very common e.g. self review or a team member approving
your PR) then the `outstanding_per_group` entry would be incremented
twice, leading to overcounting outstanding forward ports for the team.

Fixes #801
xmo-odoo added a commit that referenced this issue Jan 29, 2025
@xmo-odoo
[IMP] forwardport: show a user's outstanding tally in the main alert
8966246 
Previously the alert would show the total number of outstanding
forward ports, which most people don't care about (if they're even
logged which probably isn't the case), so that was mostly useful
for... me.

Add the current user's tally to the message as well. If the user is
logged. Which is always, because the alert only shows up if the user
has read access to PRs.

Fixes #801
xmo-odoo added a commit that referenced this issue Jan 29, 2025
@xmo-odoo
[ADD] forwardport: email reminders
892fce4 
After 6 months of sitting unmerged, forward ports will now trigger a
monthly email.

Or would, if an email server was configured on the mergebot, but
adding this now should allow debugging its working and tracking the
generation of emails through the "Delivery Failed" collection. This
way if we ever decide to actually do the thing we can just enable an
SMTP server.

Fixes #801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
forwardbot
Projects
Mergebot
Status: done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@xmo-odoo