[IMP] runbot: qualify errors on selected field #1007
Merged
+49
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-fence
force-pushed
the
17.0-qualify-other-fields-moc
branch
from
dfa75ed to
6199874
Compare
d-fence
force-pushed
the
17.0-qualify-other-fields-moc
branch
from
6199874 to
3f34aad
Compare
Williambraecky
approved these changes
Feb 4, 2025
|
Finally another idea emerged by discussing with xdo. |
The current qualifying implementation is based solely on error content. With this commit the fields on which the regular expression will apply can be choosen with checkboxes. It defaults to the `content` field.
d-fence
force-pushed
the
17.0-qualify-other-fields-moc
branch
from
3f34aad to
8cf7b95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous qualifying implementation was only qualifying errors based on error content. With this commit the field on which the qualifying applies can be selected on a qualifying regex.