Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] all/saas~18.1: Make _name or _inherit mandatory #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Gorash
Copy link
Contributor

@Gorash Gorash commented Dec 10, 2024

This is a request following the revert of the use of class names (concerning the python inheritance and typing project)

community: odoo/odoo#189889
enterprise: https://github.com/odoo/enterprise/pull/75293

@robodoo
Copy link
Contributor

robodoo commented Dec 10, 2024

Pull request status dashboard

@Gorash Gorash marked this pull request as ready for review December 11, 2024 13:21
@Gorash Gorash requested review from a team and Pirols and removed request for Pirols December 11, 2024 13:48
@Pirols
Copy link
Contributor

Pirols commented Dec 16, 2024

Isn't the _inherit sufficient here?

@jjmaksoud
Copy link
Contributor

Isn't the _inherit sufficient here?

not if the inherit is a list

@rco-odoo
Copy link
Member

@jjmaksoud

Copy link
Contributor

@aj-fuentes aj-fuentes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo delegate=rco-odoo

@rco-odoo
Copy link
Member

@robodoo r+

1 similar comment
@rco-odoo
Copy link
Member

@robodoo r+

@robodoo
Copy link
Contributor

robodoo commented Dec 18, 2024

This PR is already reviewed, reviewing it again is useless.

@robodoo
Copy link
Contributor

robodoo commented Dec 18, 2024

@Gorash @rco-odoo linked pull request(s) odoo/design-themes#1024, odoo/enterprise#75293, odoo/odoo#189889 not ready. Linked PRs are not staged until all of them are ready.

@robodoo
Copy link
Contributor

robodoo commented Dec 19, 2024

@Gorash @rco-odoo 'ci/upgrade_enterprise' failed on this reviewed PR.

1 similar comment
@robodoo
Copy link
Contributor

robodoo commented Dec 19, 2024

@Gorash @rco-odoo 'ci/upgrade_enterprise' failed on this reviewed PR.

@robodoo
Copy link
Contributor

robodoo commented Dec 19, 2024

@Gorash @rco-odoo linked pull request(s) odoo/enterprise#75293 not ready. Linked PRs are not staged until all of them are ready.

robodoo pushed a commit to odoo/odoo that referenced this pull request Dec 20, 2024
This is a request following the revert of the use of class names
(concerning the python inheritance and typing project)

closes #189889

Related: odoo/enterprise#75293
Related: odoo/upgrade#6901
Related: odoo/design-themes#1024
Related: odoo/upgrade-util#171
Signed-off-by: Raphael Collet <[email protected]>
robodoo pushed a commit to odoo/design-themes that referenced this pull request Dec 20, 2024
This is a request following the revert of the use of class names
(concerning the python inheritance and typing project)

closes #1024

Related: odoo/odoo#189889
Related: odoo/enterprise#75293
Related: odoo/upgrade#6901
Related: odoo/upgrade-util#171
Signed-off-by: Christophe Monniez (moc) <[email protected]>
robodoo pushed a commit that referenced this pull request Dec 20, 2024
This is a request following the revert of the use of class names
(concerning the python inheritance and typing project)

closes #171

Community: odoo/odoo#189889
Enterprise: odoo/enterprise#75293
Related: odoo/odoo#189889
Related: odoo/enterprise#75293
Related: odoo/upgrade#6901
Related: odoo/design-themes#1024
Signed-off-by: Raphael Collet <[email protected]>
This is a request following the revert of the use of class names
(concerning the python inheritance and typing project)

community: odoo/odoo#189889
enterprise: odoo/enterprise#75293
@rco-odoo rco-odoo force-pushed the master-assert-name-chm branch from 2a6ddaa to c7729dd Compare December 20, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants