[IMP] util.modules: new hack to override load data mode #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HydrionBurst
force-pushed
the
master-core-refactor-graph2-cwg
branch
2 times, most recently
from
5b066ef to
7fe5c89
Compare
HydrionBurst
force-pushed
the
master-core-refactor-graph2-cwg
branch
from
1cff91a to
2a208aa
Compare
KangOl
reviewed
Jan 21, 2025
|
upgradeci retry with always only base |
HydrionBurst
force-pushed
the
master-core-refactor-graph2-cwg
branch
from
2355c77 to
6df6be9
Compare
HydrionBurst
force-pushed
the
master-core-refactor-graph2-cwg
branch
from
6df6be9 to
7137df7
Compare
HydrionBurst
commented
Jan 30, 2025
HydrionBurst
force-pushed
the
master-core-refactor-graph2-cwg
branch
2 times, most recently
from
7de8679 to
1bbb64e
Compare
HydrionBurst
commented
Jan 31, 2025
src/util/modules.py
Outdated
| @@ -869,6 +869,11 @@ def force_upgrade_of_fresh_module(cr, module, init=True): | |||
| """ | |||
| Force the execution of upgrade scripts for a module that is being installed. | |||
|
|
|||
| From saas~18.2 | |||
| Odoo Standard Odoo allows to add module names to `registry._config_force_upgrade_scripts` | |||
| to force the execution of their upgrade scripts. `init=False` is not supported. | |||
There was a problem hiding this comment.
@KangOl
I am not sure if we should support force_upgrade_of_fresh_module(cr, module, init=False) in the new strategy.
Could you help me check previously when we set init=False, did we really want the data and demo to be loaded in the update mode or we just didn't want the package.init to be propagated through dependencies.
There was a problem hiding this comment.
From memory, I thought it was only for avoiding propagation.
But we have cases where the init flag messed with the noupdate flag of the records:
HydrionBurst
force-pushed
the
master-core-refactor-graph2-cwg
branch
4 times, most recently
from
9a91141 to
f0179da
Compare
HydrionBurst
force-pushed
the
master-core-refactor-graph2-cwg
branch
from
f0179da to
896ec7a
Compare
rco-odoo
approved these changes
Feb 10, 2025
Allow ``_force_upgrade_of_fresh_module`` in upgrade-util to force the execution of upgrade script for new install modules Unlike the old hack where 1. ``module_node.init`` can be changed by ``_force_upgrade_of_fresh_module`` through changing the global ``config['init']``. 2. ``module_node.init`` was propagated only through one of the longest module dependency path. The new hack uses a new explicit variable ``registry._force_upgrade_scripts`` without changing the global ``config``. odoo/odoo#189000
HydrionBurst
force-pushed
the
master-core-refactor-graph2-cwg
branch
from
896ec7a to
217ae25
Compare
|
@robodoo delegate=rco-odoo |
|
@aj-fuentes thanks! |
|
@robodoo r+ |
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 12, 2025
Before this commit ``load_module_graph`` didn't use ``update_module`` as a parameter. As a result when loading registry in ``update_module=False`` mode, ``load_module_graph`` may still upgrade 'to upgrade' modules in graph. This could happen in multi-processes mode when 1. process 1 marks module A 'to upgrade' and is reloading the registry with ``update_module=True``, which will upgrade module A during loading modules. 2. process 2 is reloading the registry with ``update_module=False`` (e.g. the registry was invalidated before and has to be reloaded for the new request). During loading the registry, all 'installed', 'to remove', 'to upgrade' but not 'to install' modules will be loaded. And since module A is 'to upgrade', ``load_module_graph`` will also upgrade it. The concurrent module upgrades will bring unexpected results. After this commit The `load_module_graph`` won't update modules when ``update_module=False`` Part-of: #189000 Related: odoo/upgrade-util#176 Signed-off-by: Raphael Collet <[email protected]>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 12, 2025
In this commit replaces graph.py with module_graph.py which decouples the module
loading order from the loading.py. The new implementation introduces the
``ModuleNode`` class, which brings several improvements over the old ``Node``
class in graph.py:
1. No dynamic attributes:
The ModuleNode class avoids dynamic attributes, making the code more
predictable and maintainable.
2. Simplified update logic:
* Removed ``node.init`` and ``node.update`` attributes, simplifying the
update conditions. Now, loading.py relies solely on ``node.state`` to
determine how to update modules.
* The ``node.demo`` attribute is now exclusively used to reflect
``ir_module_module.demo`` in the database, indicating whether demo data has
been successfully installed. This change necessitates a new strategy for
setting up demo data during module loading. Based on all our use cases, we
have removed the ``force_demo`` feature from ``Registry.new`` and
``load_modules`` and introduced a new feature, ``new_db_demo``, to
determine whether demo data should be installed for a newly initialized
database. Additionally, the ``load_module_graph`` function now includes an
``install_demo`` parameter to support the new feature.
3. Enhanced dependency management:
The new implementation stores the complete dependency relations within the
ModuleGraph, improving clarity and maintainability.
4. Optimized module serialization:
The algorithm for module serialization has been simplified and optimized,
reducing the time complexity from O(n²) to O(n log n)
Part-of: #189000
Related: odoo/upgrade-util#176
Signed-off-by: Raphael Collet <[email protected]>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 12, 2025
Thanks to the new module_graph.py which can handle the ordering of "to update" and "to upgrade" modules in ``update_module`` mode. The additional function ``load_marked_modules`` is no longer necessary and can be removed. The old variables ``loaded_modules`` and ``processed_modules`` are already consistent with ``registry._init_modules`` and ``registry.updated_modules``. Since their states are maintained within the registry, there is no need for ``load_module_graph`` to return these variables explicitly. Part-of: #189000 Related: odoo/upgrade-util#176 Signed-off-by: Raphael Collet <[email protected]>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 12, 2025
remove config['demo'] since it is not used Part-of: #189000 Related: odoo/upgrade-util#176 Signed-off-by: Raphael Collet <[email protected]>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 12, 2025
…ate'] Part-of: #189000 Related: odoo/upgrade-util#176 Signed-off-by: Raphael Collet <[email protected]>
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Feb 12, 2025
Allow ``_force_upgrade_of_fresh_module`` in upgrade-util to force the execution of upgrade script for new install modules Unlike the old hack where 1. ``module_node.init`` can be changed by ``_force_upgrade_of_fresh_module`` through changing the global ``config['init']``. 2. ``module_node.init`` was propagated only through one of the longest module dependency path. The new hack uses a new explicit variable ``registry._force_upgrade_scripts`` without changing the global ``config``. upgrade-util#176 closes #189000 Related: odoo/upgrade-util#176 Signed-off-by: Raphael Collet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new runtime option 'load_data_init' will be used for each package when loading package graph. It works like the previous package.init but more comprehensive and complete. Now if any directly or indirectly dependent module is configured 'load_data_init', the module will also be configured 'load_data_init'
odoo/odoo#189000