[FIX] modules: avoid conflicts on ir_model_data in new_module #281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a condition for the ir_module_module to exist, but it is possible that while the module doesn't exist, the ir_model_data for this (module, name) do in fact exists, which leads to the unique key failing when attepting to insert these values again. This was detected when upgrading from 11.0 to 18.0 in one run.
Contributor
|
|
Contributor
|
Strange I'm currently working in unrelated issues in 11->12 upgrade, but we have never faced any issue in this part of the code. How are you running the upgrade? |
Contributor
Author
|
As discussed, I was doing too many versions at once I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a condition for the ir_module_module to exist, but it is possible that while the module doesn't exist, the ir_model_data for this (module, name) do in fact exists, which leads to the unique key failing when attepting to insert these values again.
This was detected when upgrading from 11.0 to 18.0 in one run.