-
-
Notifications
You must be signed in to change notification settings - Fork 91
Hollow wand utilities v2 #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Soon2BeATaco
commented
Oct 17, 2025
- Stuff fixed from suggestions on previous pr
- Added "Raging Wind" spell compatibility
…re consistent across users
Summary of ChangesHello @Soon2BeATaco, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new 'Hollow Wand' module to enhance gameplay related to 'Ichor Pool' and 'Raging Wind' spells. It provides features such as automatic party chat messaging of spell cast locations and dynamic visual waypoints for these spells, including an expanding radius for 'Raging Wind' and proximity alerts. Additionally, it refines player utility functions for more precise coordinate handling and distance calculations, improving overall user experience for spell management. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new module, HollowWand, which provides message and waypoint functionality for hollow wand casting in the game. It also modifies ModuleManager to include the new module and updates PlayerUtils with helper functions for position formatting and distance calculation. The changes look good, but there are a few areas that could be improved for clarity and efficiency.
| val fps = mc.debug?.split(" ")?.get(0)?.toDoubleOrNull() ?: 60.0 | ||
| val windIncrement = 25.0 / max(60.0, fps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fps variable is used to calculate windIncrement. If mc.debug is null, split will throw an exception. Add a null check to prevent this.
| val fps = mc.debug?.split(" ")?.get(0)?.toDoubleOrNull() ?: 60.0 | |
| val windIncrement = 25.0 / max(60.0, fps) | |
| if(!showWaypoint) return | |
| val fps = mc.debug?.split(" ")?.get(0)?.toDoubleOrNull() ?: 60.0 |
| if(PlayerUtils.getDistanceTo(x, y, z) <= 25) { | ||
| PlayerUtils.alert("Raging Winds", color = Colors.MINECRAFT_RED) | ||
| modMessage("Raging Winds applied") | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alert and modMessage calls are both triggered when the player is within 25 blocks of a Raging Wind. Consider consolidating these into a single function call or a more descriptive combined message to avoid redundancy and improve clarity.
| if(PlayerUtils.getDistanceTo(x, y, z) <= 25) { | |
| PlayerUtils.alert("Raging Winds", color = Colors.MINECRAFT_RED) | |
| modMessage("Raging Winds applied") | |
| } | |
| if(PlayerUtils.getDistanceTo(x, y, z) <= 25) { | |
| PlayerUtils.alert("Raging Winds applied", color = Colors.MINECRAFT_RED) | |
| modMessage("Raging Winds applied") | |
| } |
|
Just to clarify, .DS_Store was added to gitignore because I use a mac, and those files just spawn in. They're functionally useless and invisible on my end, so this was the simplest solution to not add the files. |