Revision/simplify indexes #1158
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is an attempt to remove redundancies from the c'tor signature.
Systems with storage do not build at the moment. Results cannot be processed.
Optimisation using aggregated time should now work using the tsam.TimeSeriesAggregation object as the time index. To be adjusted (not working): * GenericStorage * result processing * ...
The new name reflects what it is. (The name "invest" was often read if it were the investment costs.)
These periods do not exist anymore.
It doesn't make sense to adjust everything (esp. result processing) for the deletion of the old multi-period feature just to have to adjust it again when introducing the new one. Thus, there is a placeholder (one period hard-coded).
At the moment, it is single period.
First asigning processed results to a variable before accessing the relevant information allows to see the results while debugging.
In the multi-period model, it will not really be an added capacity, so the old name might just stay as well.
8 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| * :math:`Y_{invest}(p)` | ||
|
|
||
| Binary variable for the status of the investment, if | ||
| :attr:`nonconvex` is `True`. | ||
| """ | ||
| m = self.parent_block() | ||
|
|
||
| def _investvar_bound_rule(block, i, o, p): | ||
| def _investvar_bound_rule(_, i, o, p): |
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
| * :math:`Y_{invest}(p)` | ||
|
|
||
| Binary variable for the status of the investment, if | ||
| :attr:`nonconvex` is `True`. | ||
| """ | ||
| m = self.parent_block() | ||
|
|
||
| def _investvar_bound_rule(block, i, o, p): | ||
| def _investvar_bound_rule(_, i, o, p): |
Check notice
Code scanning / CodeQL
Unused local variable Note
Processing expects the key "scalars" to be set. There is no reason we have to break the API here.
Optimises but results processing does not work, yet. (It's also unclear if results are correct.)
| energysystem.add(excess, gas_resource, wind, pv, demand, pp_gas) | ||
|
|
||
| storage = None | ||
| if True: |
Check warning
Code scanning / CodeQL
Constant in conditional expression or statement Warning
Name was present twice which caused problems.
|
|
||
| def _inter_storage_balance_rule(block, n, i): | ||
| """ | ||
| Rule definition for the storage balance of every storage n and | ||
| every timestep. | ||
| """ | ||
| ii = 0 | ||
| for p in m.PERIODS: | ||
| ii += len(m.es.tsa_parameters[p]["order"]) | ||
| for p in m.CAPACITY_PERIODS: |
Check failure
Code scanning / CodeQL
Suspicious unused loop iteration variable Error
These are no unit tests but integration test following the structure of example scripts. Collecting the examples using pytest fails, so they need to go.
The info was redundant, so the need to give it should be removed.
Casting collections.Counter to a list will lead to the keys being stored instead of the values. This eventually results in wrong tsam_weights (0 for single period).
Period/step is easier to stistinguish than inter/intra.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify indexes in the TSAM compatible version (esp. removing the current multi-period investment).