Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make color assignment more predictable #110

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Make color assignment more predictable #110

merged 2 commits into from
Feb 2, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Feb 1, 2024

Rationale

Fix #109

Changes

  • no more randomness in assignment of colors to package names

@benoit74 benoit74 self-assigned this Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3ca9c7) 100.00% compared to head (d3b4e3c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         1134      1134           
  Branches       212       212           
=========================================
  Hits          1134      1134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review February 1, 2024 15:10
@benoit74 benoit74 requested a review from rgaudin February 1, 2024 15:10
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rgaudin rgaudin merged commit d7c534c into main Feb 2, 2024
6 checks passed
@rgaudin rgaudin deleted the better_colors branch February 2, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make assignment of color to packages less random
2 participants