Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details pane for total usage + small stuff #95

Merged
merged 11 commits into from
Jan 23, 2024
Merged

Details pane for total usage + small stuff #95

merged 11 commits into from
Jan 23, 2024

Conversation

benoit74
Copy link
Collaborator

@benoit74 benoit74 commented Jan 22, 2024 •
edited
Loading

Rationale

Fix #55
Fix #12
Fix #93

Changes

  • implement the detail pane for total usage (reusing same component for items as package popularity)
  • fix the fallback image (for now, adding a dynamic one based on offspot configuration, including text, will be done later)
  • add a screenshot to home page

@benoit74 benoit74 self-assigned this Jan 22, 2024
@benoit74 benoit74 changed the title Add a screenshot of home dashboard to README.md Details pane for total usage + small stuff Jan 22, 2024
@codecov Codecov
Copy link

codecov bot commented Jan 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9733aed) 100.00% compared to head (cbf5041) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           37        37           
  Lines         1090      1092    +2     
  Branches       202       202           
=========================================
+ Hits          1090      1092    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benoit74 benoit74 marked this pull request as ready for review January 22, 2024 14:06
@benoit74 benoit74 requested a review from rgaudin January 22, 2024 14:06
@benoit74
Copy link
Collaborator Author

Hum, some commits were missing ...

rgaudin
rgaudin approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; please check the PID thing before merging.

I did not run the code so I'm not completely clear about the inverted usage

backend/src/offspot_metrics_backend/main.py Outdated Show resolved Hide resolved
frontend/src/components/PackageElement.vue Outdated Show resolved Hide resolved
@benoit74
Do not wait for observer indefinitely on stop
7c404d6
@benoit74
Revert "Really stop docker container when needed"
0fc9bae 
This reverts commit 79e1f15.
This change was:
- not needed (issue about Docker container not stopping properly is only
  linked to the `--reload` option used only in dev, not prod)
- risky / sketchy / misleading
@benoit74
Copy link
Collaborator Author

I did not run the code so I'm not completely clear about the inverted usage

inverted means "black graphics on colorful background" while default (non-inverted) means "colorful graphic on white background"

image

@benoit74 benoit74 mentioned this pull request Jan 23, 2024
Closed
@benoit74 benoit74 merged commit 97f927b into main Jan 23, 2024
6 checks passed
@benoit74 benoit74 deleted the total_usage_details branch January 23, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgaudin rgaudin rgaudin approved these changes

Assignees

@benoit74 benoit74

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@benoit74 @rgaudin