-
Notifications
You must be signed in to change notification settings - Fork 456
[v2.3.x] Cherry-picked fixes for v2.3.1 #11484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncy. The 'gettid()' function is not POSIX compliant, and older versions of glibc may not have that function available in unistd.h, causing a compile failure. This changes the call to 'getpid()', which is POSIX compliant and should always be present in glibc. Signed-off-by: Ben Lynam <[email protected]> (cherry picked from commit 7660f36)
Some ROCR build errors were introduced with the IPC asynchronous support. This resolves those errors. Signed-off-by: Lindsay Reiser <[email protected]> (cherry picked from commit 1fc5248)
…abled An OPX build with ROCR resulted in a segmentation fault for a CPU only memory workload because of an error opening the IPC cache when ROCR IPC is enabled, but ROCR HMEM was not initialized. The log shows: opx:domain:opx_hmem_open_domain():191<warn> Error opening IPC Cache ret=-38 (Unknown error -38). The OPX open domain path has been updated to only open the IPC cache if HMEM is initialized and IPC is enabled. Signed-off-by: Lindsay Reiser <[email protected]> (cherry picked from commit 95a9e8d)
Fixing byte counter for atomic fetch and array length in bounce buffer. Signed-off-by: Archana Venkatesha <[email protected]> (cherry picked from commit e0d823c)
Fixing header extension for 16B. Signed-off-by: Archana Venkatesha <[email protected]> (cherry picked from commit d60532d)
0 byte write with CQ data was not posting because there is no data to send after the RTS/CTS exchange. Updated to post the CQ data when receiving the RTS and the sender completes when receiving the CTS. Other minor changes: Tail was not set properly in fi_opx_ep_rx_process_header() Added the endpoint pointer to the flight recorder dump Added opx_debug_ep_list_dump to dump the endpoint list Signed-off-by: Lindsay Reiser <[email protected]> (cherry picked from commit 110cdbe)
Signed-off-by: Jianxin Xiong <[email protected]> (cherry picked from commit 8f506de)
Gcc 15 complains that the length parameter for strncpy() is derived from the source string. It is not a real concern since the result is guaranteed to be less than the buffer size due to the MIN operation. However, the calculation is slightly off anyway. So rewite the logic to kill two birds with one stone. Signed-off-by: Jianxin Xiong <[email protected]> (cherry picked from commit 502dd95)
aingerson
approved these changes
Oct 9, 2025
Contributor
|
AWS CI is having issue now and I will update whether the failure is related |
belynam
approved these changes
Oct 9, 2025
Contributor
Author
|
bot:aws:retest |
Contributor
|
@j-xiong AWS CI issue is mitigated, so we should expect a PASS this time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.