prov/util: memhooks: avoid RTLD_NEXT usage #11559
Draft
+26
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlsym(RTLD_NEXT, ...) may legally return any entrypoint which eventually finds its way into the requested symbol, in any library appearing in load-order after the current library. Load order can be messy in HPC runtime environments, or due to inconsistencies introduced by vendor toolchains and vendor packaging mechanisms. All current intercepts are expected to resolve to libc, so just do an explicit search inside libc to prevent accidentally resolving eg: PLT stubs. Fixes: ofiwg#11451 Signed-off-by: Nicholas Sielicki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dlsym(RTLD_NEXT, ...) may legally return any entrypoint which eventually finds its way into the requested symbol, in any library appearing in load-order after the current library. Load order can be messy in HPC runtime environments, or due to inconsistencies introduced by vendor toolchains and vendor packaging mechanisms.
All current intercepts are expected to resolve to libc, so just do an explicit search inside libc to prevent accidentally resolving eg: PLT stubs.
Fixes: #11451
Marked as WIP for now.