-
Notifications
You must be signed in to change notification settings - Fork 456
prov/efa, fabtests: Fix cq data size in efa-rdm pkt post, fix cq_data test bugs #11663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 10ca04b introduced a bug that introduces an 16 bit cq data intermediate variable when passing to device. uint16_t is too small and will silently corrupt when application is using more than 16 bits while efa provider supports 32 bits. This patch fixes it. Signed-off-by: Shi Jin <[email protected]>
1470a19 to
9f9449f
Compare
Contributor
Author
|
@j-xiong can u review the fabtests change |
j-xiong
reviewed
Nov 25, 2025
The current run_test() has a bug, that the cq data check and cq data size check are setting the same return code. That means when a cq data check failed but cq data size check succeeds, the return code will be still 0. This patch fixes this issue by making the test return error directly when any check failed. Signed-off-by: Shi Jin <[email protected]>
9f9449f to
da6df41
Compare
j-xiong
approved these changes
Nov 25, 2025
a-szegel
approved these changes
Nov 25, 2025
Contributor
|
Hey @j-xiong, Why did this PR fail intel CI? |
Contributor
Author
|
the appveyor failure looks unrelated |
Contributor
|
@a-szegel Unrelated mpich test suite failure with tcp - bad file descriptor. You can ignore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 10ca04b introduced a bug that uses a
16 bit cq data intermediate variable when passing to
device. uint16_t is too small and
will silently corrupt when application is using more
than 16 bits while efa provider supports 32 bits.
This patch fixes it.