refactor: api, tables, and ui cleanup and refactor code, add e2e tests #96
Conversation
|
Caution Review failedFailed to post review comments. WalkthroughThis pull request introduces a comprehensive refactor and enhancement of the Arcane application, affecting UI components, state management, API service abstractions, testing, and documentation. Major changes include the replacement of legacy table cell and action components with inline declarative table definitions, centralized confirmation dialog handling, and the introduction of dedicated API service classes for containers, images, stacks, networks, volumes, and users. State management is consolidated into grouped objects, and all resource lifecycle actions now use consistent async flows with utility functions for error handling and toasts. Extensive end-to-end Playwright tests and supporting test infrastructure are added. Documentation is overhauled, with new user guides and the removal of outdated or redundant files. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UIComponent
participant ConfirmDialog
participant APIService
participant Backend
User->>UIComponent: Clicks resource action (start/stop/remove/etc.)
UIComponent->>ConfirmDialog: openConfirmDialog({action, message, callback})
ConfirmDialog->>User: Shows confirmation dialog
User->>ConfirmDialog: Confirms action
ConfirmDialog->>APIService: Calls API method (e.g., remove(id))
APIService->>Backend: Sends HTTP request
Backend-->>APIService: Returns API response
APIService->>ConfirmDialog: Resolves callback with result
ConfirmDialog->>UIComponent: Closes dialog, triggers UI update
UIComponent->>User: Shows toast/feedback, updates state
Assessment against linked issues
Possibly related PRs
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
playwright.config.tsOops! Something went wrong! :( ESLint: 9.25.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@sveltejs/adapter-node' imported from /svelte.config.js scripts/init-test-env.tsOops! Something went wrong! :( ESLint: 9.25.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@sveltejs/adapter-node' imported from /svelte.config.js src/app.d.tsOops! Something went wrong! :( ESLint: 9.25.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@sveltejs/adapter-node' imported from /svelte.config.js
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
kmendell
changed the title
…es build errors for now
kmendell
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -49,7 +64,7 @@ | |||
| }, | |||
| columns, | |||
| getRowId: idKey | |||
| ? (originalRow: TData, index: number, parent?: RowData) => { | |||
| ? (originalRow: TData, _index: number, _parent?: RowData) => { | |||
Check failure
Code scanning / ESLint
Disallow unused variables Error
Copilot Autofix
AI 3 months ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
kmendell
changed the title
kmendell
changed the title
| @@ -12,15 +11,15 @@ | |||
| let { | |||
| open = $bindable(false), | |||
| userToEdit = $bindable<User | null>(null), | |||
| roles = [] | |||
| roles = [], | |||
| onSubmit = $bindable((_data: { user: Partial<User> & { password?: string }; isEditMode: boolean; userId?: string }) => {}) | |||
Check failure
Code scanning / ESLint
Disallow unused variables Error
Copilot Autofix
AI 3 months ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
| import { Button } from '$lib/components/ui/button/index.js'; | ||
| import { Download, AlertCircle, RefreshCw, HardDrive, Trash2, Loader2, ChevronDown, CopyX } from '@lucide/svelte'; | ||
| import { Download, AlertCircle, HardDrive, Trash2, Loader2, ChevronDown, CopyX, Ellipsis, ScanSearch, Plus } from '@lucide/svelte'; |
Check failure
Code scanning / ESLint
Disallow unused variables Error
Copilot Autofix
AI 3 months ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
| @@ -2,65 +2,135 @@ | |||
| import type { PageData } from './$types'; | |||
| import * as Card from '$lib/components/ui/card/index.js'; | |||
| import { Button } from '$lib/components/ui/button/index.js'; | |||
| import { Plus, AlertCircle, Layers, RefreshCw, Upload, FileStack } from '@lucide/svelte'; | |||
| import { Plus, AlertCircle, Layers, Upload, FileStack, Loader2, Play, RotateCcw, StopCircle, Trash2, Ellipsis, Pen, Import } from '@lucide/svelte'; | |||
Check failure
Code scanning / ESLint
Disallow unused variables Error
Copilot Autofix
AI 3 months ago
Copilot could not generate an autofix suggestion
Copilot could not generate an autofix suggestion for this alert. Try pushing a new commit or if the problem persists contact support.
Fixes: #95
Fixes: #80
Fixes: #65
TODO:
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
Documentation
Chores
.gitignore, and added VS Code settings for Copilot.Style
Tests