Skip to content

feat: Updating Semantic Color Tokens #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 28, 2025

Conversation

ramonmulia
Copy link
Collaborator

@ramonmulia ramonmulia commented Apr 17, 2025

Description

Type of Issue

  • 🚀 Feature
  • 🐛 Bug
  • 🔧 Chore
  • 🌐 Docs

Checklist

  • I have included relevant attachments for user testing (e.g., screenshots of Storybook showcasing the changes).
  • I have added/updated tests to cover the changes made (if applicable).
  • I have updated the documentation site content (if applicable).
  • I have added or updated the example folder to reflect any component changes (if applicable).

Related Issues

26762

Additional Notes

Copy link
Collaborator

@pregno pregno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a couple of comments that may require a dedicated meeting.
What I would like to have is something like this:

Primitive

  • base colors swatches

Brand

  • brand specific color swatches (e.g. emerald for gov.ie, purple for doete)

Semantic

  • uses brand tokens

@ramonmulia ramonmulia merged commit 164e3cb into main Apr 28, 2025
10 of 14 checks passed
@ramonmulia ramonmulia deleted the feat/update-semantic-color-tokens branch April 28, 2025 09:41
@pregno pregno mentioned this pull request Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants