Fix staticcheck in generated code #1424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The saving of elem in origElem is not needed in all cases. staticcheck finds those cases and complains. This fix removes the saves in cases where they are not needed afterwards.
|
I fixed the commit message that the pipeline complained in the previous pull request. |
tdakkota
approved these changes
Mar 12, 2025
AlphaOne1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated router uses a variable - origElem - to save the elem variable while potentially modifying it. This elem is used after in some cases. If it is not used, the staticcheck complains about setting a variable without further use. This patch removes the origElem save in cases where elem is not used afterwards, fixing the staticcheck.