feat: support map #197
Merged
feat: support map #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sasha Melentyev <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for map fields in the schema generation process by updating the generator logic and adding new map field definitions, along with corresponding OpenAPI schema components.
- Updated internal generator to handle map entries and validate map key kinds.
- Introduced helper functions isUnsupportedMapKeyKind and mkMapSchema to construct appropriate schemas for map fields.
- Updated OpenAPI definitions and proto files to include new map field types.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/gen/schema.go | Enhances schema generation by skipping map entry messages and validating map key kinds via helpers. |
| example/openapi.yaml | Adds new OpenAPI schema components for maps with string, int32, int64, uint32, and uint64 keys. |
| example/message.proto | Introduces new map field definitions for various key types. |
Signed-off-by: Sasha Melentyev <[email protected]>
tdakkota
reviewed
May 26, 2025
Signed-off-by: Sasha Melentyev <[email protected]>
Signed-off-by: Sasha Melentyev <[email protected]>
Signed-off-by: Sasha Melentyev <[email protected]>
Signed-off-by: Sasha Melentyev <[email protected]>
tdakkota
reviewed
May 26, 2025
Signed-off-by: Sasha Melentyev <[email protected]>
Signed-off-by: Sasha Melentyev <[email protected]>
tdakkota
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.